[#29700] Testsuite PoC: Ability to configure server run-mode within the JUnit5 framework#29926
Closed
lhanusov wants to merge 1 commit into
Closed
[#29700] Testsuite PoC: Ability to configure server run-mode within the JUnit5 framework#29926lhanusov wants to merge 1 commit into
lhanusov wants to merge 1 commit into
Conversation
75bea31 to
5d29270
Compare
This was referenced Jun 11, 2024
…within the JUnit5 framework. Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
stianst
requested changes
Jun 19, 2024
stianst
left a comment
Contributor
There was a problem hiding this comment.
Actual configuration of the server shouldn't be externalized, that should live within Java code. There may be some configuration that should be externalized in the future, but not certain if that is needed or wanted at all.
For this issue all we want is the ability to configure what run mode that should be used for the server, and I'm thinking we probably want to go more in the direction of https://github.com/orgs/keycloak/projects/42?pane=issue&itemId=67817617 and https://github.com/orgs/keycloak/projects/42?pane=issue&itemId=63724099
Contributor
Contributor
Author
|
As @stianst mentioned it will be decomposed into those two issues assigned to @wojnarfilip and @ikhomyn, and I will focus on run mode stuff itself: #31109. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29700
Dependency: #29517