Skip to content

Testsuite PoC - Ability to configure server run-mode within the JUnit5 framework#31109

Merged
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:29700
Jul 9, 2024
Merged

Testsuite PoC - Ability to configure server run-mode within the JUnit5 framework#31109
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:29700

Conversation

@lhanusov

@lhanusov lhanusov commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

Closes #29700

@stianst stianst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be an idea to add AbstractKeycloakTestServerSupplier with all the boiler plate and one abstract method like:

public abstract KeycloakTestServer getServer()

jonkoops
jonkoops previously approved these changes Jul 9, 2024

@jonkoops jonkoops left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…5 framework

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
@stianst stianst enabled auto-merge (squash) July 9, 2024 12:06
@stianst stianst merged commit 5fdb572 into keycloak:main Jul 9, 2024
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
…5 framework (keycloak#31109)

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testsuite PoC - Ability to configure server run-mode within the JUnit5 framework

3 participants