Support for service accounts when fetch roles is enabled #30687
Merged
Conversation
b2d903c to
1ffa090
Compare
Contributor
|
@Romain7495 Thanks. I've updated your branch and force-pushed an additional commit to support service accounts when Also changed the target branch of this PR to main. Once we merge it, I'll try to include it in the next patch release. Does it work for you? |
Contributor
Author
|
Thanks @pedroigor LGTM |
Closes keycloak#30444 Signed-off-by: Romain LABAT <contact@romainlabat.fr>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
This was referenced Jun 25, 2024
pedroigor
approved these changes
Jun 25, 2024
Contributor
|
@Romain7495 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #30444
@pedroigor Wdyt about just checking if
clientIdis not set ?