Skip to content

Backport to add support for service accounts when fetch roles is enabled#30786

Merged
ahus1 merged 1 commit into
keycloak:release/25.0from
Romain7495:backport-30444
Jun 28, 2024
Merged

Backport to add support for service accounts when fetch roles is enabled#30786
ahus1 merged 1 commit into
keycloak:release/25.0from
Romain7495:backport-30444

Conversation

@Romain7495

@Romain7495 Romain7495 commented Jun 26, 2024

Copy link
Copy Markdown
Contributor

Backport for: #30687
Fixes: #30444

@pedroigor does is fit for you ?

@Romain7495 Romain7495 requested review from a team as code owners June 26, 2024 07:58
This was referenced Jun 26, 2024
Closed
Closed
@Romain7495 Romain7495 force-pushed the backport-30444 branch 4 times, most recently from fa82cc1 to 7019c94 Compare June 27, 2024 11:39
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jun 27, 2024
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Jun 27, 2024

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.AppInitiatedActionWebAuthnTest#proceedSetupWebAuthnLogoutOtherSessionsChecked

Keycloak CI - WebAuthn IT (chrome)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@Romain7495

Romain7495 commented Jun 27, 2024

Copy link
Copy Markdown
Contributor Author

flaky test appeared just after rebasing release/25.0 branch

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Jun 27, 2024
Merged
@Romain7495 @pedroigor
Support for service accounts when fetch roles is enabled (keycloak#30687
5871fde 
)

Support for service accounts when fetch roles is enabled

Signed-off-by: Romain LABAT <contact@romainlabat.fr>
Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Co-authored-by: Pedro Igor <pigor.craveiro@gmail.com>
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Jun 27, 2024
Closed
ahus1
ahus1 approved these changes Jun 28, 2024
View reviewed changes

@ahus1 ahus1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on parent PR's review.

@ahus1 ahus1 merged commit 84c9dd5 into keycloak:release/25.0 Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Romain7495 @ahus1