Skip to content

Added template overrides#31106

Merged
edewit merged 3 commits into
keycloak:mainfrom
edewit:issue-31021
Jul 15, 2024
Merged

Added template overrides#31106
edewit merged 3 commits into
keycloak:mainfrom
edewit:issue-31021

Conversation

@edewit

@edewit edewit commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

fixes: #31021

@edewit edewit requested review from a team as code owners July 8, 2024 11:59
@edewit edewit self-assigned this Jul 8, 2024
@edewit

edewit commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

image
image

fixes: keycloak#31021
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit

edewit commented Jul 9, 2024

Copy link
Copy Markdown
Contributor Author

@xianli123 right, made "cancel button" a link

@thomasdarimont

Copy link
Copy Markdown
Contributor

@edewit I think you could also fix the invalid css selector in the javascript snippet,
.kc-recovery-codes-list li should be #kc-recovery-codes-list li .

See: #31260

@thomasdarimont thomasdarimont left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the proper css selector for the recovery-codes-list.

Comment thread themes/src/main/resources/theme/base/login/login-recovery-authn-code-config.ftl Outdated
Comment thread themes/src/main/resources/theme/keycloak.v2/login/resources/css/styles.css Outdated
* addressed PR comments

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit edewit merged commit 0a5a082 into keycloak:main Jul 15, 2024
@edewit edewit deleted the issue-31021 branch July 15, 2024 12:51
edewit added a commit to edewit/keycloak that referenced this pull request Jul 16, 2024
@hmlnarik hmlnarik mentioned this pull request Jul 16, 2024
2 tasks
hmlnarik pushed a commit that referenced this pull request Jul 16, 2024
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
* Added template overrides

fixes: keycloak#31021
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* pr review comment

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* * removed duplicated javascript and fixed formatting
* addressed PR comments

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling of recovery codes seems wrong

3 participants