Skip to content

Fix css selector for recovery-codes-list (#31260,#31287)#31286

Closed
thomasdarimont wants to merge 2 commits into
keycloak:mainfrom
thomasdarimont:issue/gh-31260-fix-recovery-code-download
Closed

Fix css selector for recovery-codes-list (#31260,#31287)#31286
thomasdarimont wants to merge 2 commits into
keycloak:mainfrom
thomasdarimont:issue/gh-31260-fix-recovery-code-download

Conversation

@thomasdarimont

@thomasdarimont thomasdarimont commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

The recovery-codes-list should be addressed by element ID not by CSS class.
Also the css style from keycloak v1 login theme was not applied with keycloak.v2 login theme.

Fixes #31260
Fixes #31287

Fixed list rendering:
image

@thomasdarimont thomasdarimont requested review from a team as code owners July 15, 2024 07:55
@rmartinc rmartinc requested a review from jonkoops July 15, 2024 08:00
@thomasdarimont thomasdarimont force-pushed the issue/gh-31260-fix-recovery-code-download branch from 1372f05 to 1c1a28b Compare July 15, 2024 08:12
…oak#31260,keycloak#31287)

The recovery-codes-list should be addressed by element ID not by CSS class.

Fixes keycloak#31260
Fixes keycloak#31287

Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
@thomasdarimont thomasdarimont force-pushed the issue/gh-31260-fix-recovery-code-download branch from 1c1a28b to e8aec76 Compare July 15, 2024 08:12
…gin theme

Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
@thomasdarimont thomasdarimont changed the title Fix css selector for recovery-codes-list parseRecoveryCodeList (#31260) Fix css selector for recovery-codes-list (#31260,#31287) Jul 15, 2024
@thomasdarimont

Copy link
Copy Markdown
Contributor Author

Closing this in favour of #31106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recovery code List shows duplicate numeration Download of Recovery Codes broken. File contains no Recovery Codes.

1 participant