[Windows] Stabilizing flaky Quarkus unit tests - #35638
Merged
Merged
Conversation
vmuzikar
reviewed
Dec 5, 2024
vmuzikar
left a comment
Contributor
There was a problem hiding this comment.
There seems to be a compilation error.
Pepo48
marked this pull request as draft
December 5, 2024 09:16
Closes: keycloak#35405 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
Author
|
@vmuzikar I decided to utilize |
shawkins
reviewed
Dec 5, 2024
shawkins
left a comment
Contributor
There was a problem hiding this comment.
Could this be done in a before all, with a after all that removes the setting?
Closes: keycloak#35405 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
Author
|
@shawkins sure, it can be done that way. We just need to leave the port setting annotated with |
Contributor
|
@Pepo48 Do you want to take it out of draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #35405