fix: limit the scope of when a single transaction is used for import - #37990
Merged
Conversation
closes: keycloak#34364 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar
reviewed
Mar 12, 2025
| @Override | ||
| public boolean useExistingSession() { | ||
| return true; | ||
| return ExportImportConfig.isSingleTransaction(); |
Contributor
There was a problem hiding this comment.
This was already true before the change. We're now calling ExportImportConfig.setSingleTransaction(true); which should have the same effect, no? Are we sure this is the correct fix?
Contributor
Author
There was a problem hiding this comment.
We're setting it to true now for only one specific import case - when we also need to create the bootstrap admin user.
Contributor
There was a problem hiding this comment.
Ah, right. Thanks for the explanation.
vmuzikar
approved these changes
Mar 12, 2025
| @Override | ||
| public boolean useExistingSession() { | ||
| return true; | ||
| return ExportImportConfig.isSingleTransaction(); |
Contributor
There was a problem hiding this comment.
Ah, right. Thanks for the explanation.
|
Thanks for the fix! Looks good! |
Member
|
@vmuzikar - no, there is export/import scenario with a larger amount of users in the benchmark project. |
pedroigor
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #34364