updated NL messages to complete missing translations and improve exist…#38685
Conversation
ahus1
left a comment
There was a problem hiding this comment.
Thank you for the pull request.
Please add a sign-off to your PR as outlined in the CONTRIBUTING.md guide. Then force-push your changes to the PR branch.
f7f424d to
788105b
Compare
|
@janher - I pushed one commit as out automatic checks complained: One of the HTML tags was incomplete. Another things is single quotes ( If you have a working Java/Maven environment, you can run the checks locally using With the latest commit 502c6144672c47feeabdeb98f271790ec5b9322f this should now be fine and should build. We now need a review of a second native NL speaker to approve your changes. Maybe @jonkoops has the time to do it, or you ask a friend or colleague to review the changes in the PR. Thanks! |
There was a problem hiding this comment.
Here the word 'credential' is used, but before the Dutch variant 'aanmeldgegevens' is used, this should be consistent.
There was a problem hiding this comment.
I agree with you about being consistent.
I believe this line was already in the file, and I just moved it up so the key was in the same place as in the English messages.
I'm actually on the fence which one we should use.
The argument for using "credential", would be that it is closest to the English word. I imagine this message will end up with an administrator sooner or later, and the Admin UI is not available in Dutch (and the administrators that I know, prefer the English UI for managing more technical settings).
When using "aanmeldgegevens", end users can imagine more easily that it is about something they use to sign in, decreasing the chance that administrators will get questions.
I don't think the concept of a credential is presented in the Account UI, The relevant page is called "signing in" ("aanmelden").
All in all, I have a slight preference for "aanmeldgegevens", what do you prefer?
There was a problem hiding this comment.
My preference would also be 'aanmeldgegevens', so let's go with that 👍
jonkoops
left a comment
There was a problem hiding this comment.
LGTM, let's handle #38685 (comment) as a possible follow up
30d3119 to
24beb05
Compare
…ing translations Closes keycloak#38614 Signed-off-by: Jan Herrygers <jherrygers@vaa.com>
Closes keycloak#38614 Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
Closes 38614 Signed-off-by: Jan Herrygers <jherrygers@vaa.com>
24beb05 to
8f63d88
Compare
|
@janher - with this PR merged, you are now ready to do perform the next updates in the Weblate UI directly. |
updated NL messages to complete missing translations and improve existing translations
Closes #38614