Checking password and OTP are present and can be converted#41922
Open
vivekksk wants to merge 1 commit into
Open
Checking password and OTP are present and can be converted#41922vivekksk wants to merge 1 commit into
vivekksk wants to merge 1 commit into
Conversation
closes keycloak#41640 Signed-off-by: Vivek Shanmughan <vivek.shanmughan@aryaka.com>
Contributor
|
@pedroigor can you trigger the CI for this one? |
Contributor
|
Hi @vivekksk, thank you for being the first to submit a fix for this issue - your approach of validating the required fields and throwing a PR #49316 independently arrived at the same approach and also includes an integration test, so we'll be moving forward with that one. We're closing this PR as superseded, but want to acknowledge that you got the fix right first. Thank you for the contribution! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #41640