Fix token type hint injection vulnerability in TokenIntrospectionEndpoint - #46752
Merged
Merged
Conversation
…oint - Changed error message to static string to prevent reflection of user input - Added event.detail(Details.TOKEN_TYPE, tokenTypeHint) for server-side auditing - Added event.error(Errors.INVALID_REQUEST) before throwing exception - Prevents potential log injection and issues in downstream systems Signed-off-by: Shashank Goel <goelshashank13@gmail.com>
2 tasks
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
ahus1
approved these changes
Mar 3, 2026
ahus1
enabled auto-merge (squash)
March 3, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security vulnerability in the
TokenIntrospectionEndpointwhere unsanitized user input from thetoken_type_hintparameter was being reflected directly into error responses.Changes Made
event.detail(Details.TOKEN_TYPE, tokenTypeHint)for server-side auditingevent.error(Errors.INVALID_REQUEST)before throwing exceptionBefore
{ "error": "invalid_request", "error_description": "Unsupported token type [ATTACKER_INPUT]." }After
{ "error": "invalid_request", "error_description": "Unsupported token type." }The token_type_hint value is now properly logged in the server's audit logs via event.detail() for debugging purposes, without exposing it in the client-facing error response.
Security Impact
This fix prevents:
Log injection attacks through malicious token_type_hint values
Potential issues in downstream systems that render the error_description
Information leakage through error message reflection
Closes #46689
Signed-off-by: Shashank Goel goelshashank13@gmail.com