Repository navigation
Fix NPE for incomplete deprecated password credentials - #46767
Closed
LouisLau-art wants to merge 2 commits into
Closed
LouisLau-art wants to merge 2 commits into
LouisLau-art wants to merge 2 commits into
Conversation
Signed-off-by: Louis Shawn <louis.shawn@qq.com>
Contributor
|
@pedroigor can you run the CI for this PR? |
Member
|
CI running. @LouisLau-art - Usually we would like to see a test case for changes. Leaving it to @sguilhen to decide if this is necessary here. |
Author
|
Superseded by #46840 (same patch with DCO signed commits). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullPointerExceptionwhen converting deprecated password credentials that are missing required legacy fieldsModelExceptionwith a clear validation message instead, so user creation returns a controlled bad request pathWhy
RepresentationToModel.convertDeprecatedCredentialsFormatunboxedhashIterationsfrom a nullableIntegerin legacy credential payloads. For payloads like{ "type": "password" }this caused an NPE and surfaced as an uncaught server error.Verification
./mvnw -pl server-spi-private -am -Dtest=RepresentationToModelTest test -DskipTests=falseFixes #41640