Skip to content

Enforce resource server predicates if one was given despite the IS_ADMIN flag - #48385

Merged
stianst merged 1 commit into
keycloak:mainfrom
pedroigor:issue-48324
May 4, 2026
Merged

Enforce resource server predicates if one was given despite the IS_ADMIN flag#48385
stianst merged 1 commit into
keycloak:mainfrom
pedroigor:issue-48324

Conversation

@pedroigor

@pedroigor pedroigor commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Closes #48324

@pedroigor
pedroigor requested review from a team as code owners April 22, 2026 20:41
@pedroigor pedroigor mentioned this pull request Apr 22, 2026
Closed
2 tasks
This was referenced Apr 23, 2026
Closed
Closed
Closed
@keycloak-github-bot

keycloak-github-bot Bot commented Apr 23, 2026

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.singleUseObject.SingleUseObjectModelTest#testCluster

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

org.keycloak.testsuite.model.user.UserModelTest#testAddDirtyRemoveFederationUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
	at org.keycloak.models.utils.KeycloakModelUtils.runJobInTransactionWithResult(KeycloakModelUtils.java:463)
	at org.keycloak.models.utils.KeycloakModelUtils.runJobInTransactionWithResult(KeycloakModelUtils.java:447)
	at org.keycloak.testsuite.model.KeycloakModelTest.inComittedTransaction(KeycloakModelTest.java:590)
	at org.keycloak.testsuite.model.KeycloakModelTest.inComittedTransaction(KeycloakModelTest.java:578)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 23, 2026
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

mposolda
mposolda previously approved these changes Apr 27, 2026
View reviewed changes
@pedroigor
pedroigor force-pushed the issue-48324 branch 2 times, most recently from 555c4a7 to 8e4efbe Compare April 28, 2026 18:00
This was referenced Apr 28, 2026
Closed
Closed
@stianst stianst self-assigned this Apr 29, 2026
@pedroigor
Enforce resource server predicates if one was given despite the IS_AD…
2c32094 
…MIN flag

Closes keycloak#48324

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
@stianst
stianst merged commit fd47bda into keycloak:main May 4, 2026
84 of 86 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
pedroigor added a commit to pedroigor/keycloak that referenced this pull request Jun 3, 2026
@pedroigor
Enforce resource server predicates if one was given despite the IS_AD…
ed714ee 
…MIN flag (keycloak#48385)

Closes keycloak#48324

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
pedroigor added a commit to pedroigor/keycloak that referenced this pull request Jun 3, 2026
@pedroigor
Enforce resource server predicates if one was given despite the IS_AD…
dc9e52d 
…MIN flag (keycloak#48385)

Closes keycloak#48324

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
stianst pushed a commit that referenced this pull request Jun 4, 2026
@pedroigor
Enforce resource server predicates if one was given despite the IS_AD…
06337a5 
…MIN flag (#48385) (#49668)

Closes #48324

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@pedroigor @sashyo
Enforce resource server predicates if one was given despite the IS_AD…
a187cd0 
…MIN flag (keycloak#48385)

Closes keycloak#48324

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda left review comments
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@sguilhen sguilhen sguilhen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stianst stianst

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UMA IS_ADMIN filter breaks ticket finding

4 participants

@pedroigor @sguilhen @mposolda @stianst