Repository navigation
Propagate SAML session ID change setting in DeploymentBuilder - #49604
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Propagates the SAML SP setting turnOffChangeSessionIdOnLogin into the runtime SamlDeployment built by DeploymentBuilder, and adds a regression test to ensure key SP configuration fields are mapped correctly.
Changes:
- Map
turnOffChangeSessionIdOnLoginfrom SP config intoSamlDeploymentinDeploymentBuilder. - Add a new SAML adapter XML test resource containing representative SP/IDP settings (including the new flag).
- Add a focused regression test that asserts
DeploymentBuildermaps select SP fields as expected.
| File | Description |
|---|---|
| adapters/saml/core/src/main/java/org/keycloak/adapters/saml/config/parsers/DeploymentBuilder.java | Propagates the turnOffChangeSessionIdOnLogin SP setting into the built deployment. |
| adapters/saml/core/src/test/java/org/keycloak/adapters/saml/DeploymentBuilderTest.java | Adds a regression test for SP-field mapping and refactors XML loading into a helper. |
| adapters/saml/core/src/test/resources/org/keycloak/adapters/saml/config/parsers/keycloak-saml-deployment-builder-mapping.xml | New test fixture XML capturing SP/IDP settings used by the mapping regression test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
c4e5564 to
386435b
Compare
lhanusov
left a comment
There was a problem hiding this comment.
@SchubertS96 Hi Sebastian, can you please rebase to latest main? Fix and tests seems ok, to me.
Preserve the SP turnOffChangeSessionIdOnLogin setting when building the runtime SAML deployment and add a regression test for the mapped SP configuration fields. Closes keycloak#49601 Signed-off-by: Sebastian Schubert <sebastian.schubert@tngtech.com>
386435b to
9b7078e
Compare
|
@lhanusov Hi Lukas, sorry for the delay. Rebase is done. |
mposolda
left a comment
There was a problem hiding this comment.
@SchubertS96 @lhanusov Thanks!
Summary
turnOffChangeSessionIdOnLoginSP setting whenDeploymentBuildercreates the runtime SAML deploymentDeploymentBuilderTesting
.\mvnw.cmd -pl adapters/saml/core -am -Dtest=DeploymentBuilderTest test.\mvnw.cmd spotless:applyIssue
Closes #49601
AI usage
AI agents were used to help draft and refine the code changes and test updates. All changes were reviewed and understood before submission.