fix: changing the error log to work with an unoptimized image#49384
Merged
Conversation
closes: keycloak#49383 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
michalvavrik
approved these changes
May 28, 2026
michalvavrik
left a comment
Member
There was a problem hiding this comment.
Changes itself looks fine, thanks.
As far as reason for change, why now and what has changed:
- there is not whole lot of information, my reasoning is that the test is only passing when custom image is used which happens in the Github CI via
-Dtest.operator.custom.image=custom-keycloak, but locally I may not set it and still want tests to be passing. Put it that way - LGTM.
Thanks
Contributor
Author
Yes, sorry that is effectively in the issue, but not directly stated on the PR. The further backstory is that productization was running this test without a custom image in a pipeline and noticed it didn't pass. |
shawkins
marked this pull request as ready for review
May 28, 2026 11:37
vmuzikar
pushed a commit
that referenced
this pull request
May 29, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ak#49384) closes: keycloak#49383 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #49383