Throw exception and rollback when token verification fails in reset credentials#50859
Merged
Conversation
…redentials Closes keycloak#50850 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures failed action-token verification rolls back credential updates, preventing reuse of password-reset links.
Changes:
- Throws
ErrorPageExceptionwhen action-token verification fails. - Marks transactions rollback-only when rendering this exception.
- Verifies the valid password remains unchanged after duplicate reset attempts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
AuthenticationManager.java |
Throws on invalid or reused action tokens. |
ErrorPageException.java |
Marks the current transaction for rollback. |
ResetPasswordTest.java |
Tests password preservation after duplicate reset. |
mabartos
reviewed
Jul 14, 2026
ahus1
approved these changes
Jul 15, 2026
This was referenced Jul 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50850
Throw an exception and rollback the transaction when
ErrorPageExceptionis thrown. I have changed to do the rollback when this exception is thrown. I think that it's OK as it is used just a few times and it makes sense (we are doing the same in other exceptions). If you think that it is better just do the rollback for the the reset credentials case, just let me know.