Add lower-bound validation on SCIM count parameter#50887
Merged
Conversation
Closes keycloak#50471 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds lower-bound handling for SCIM pagination count so negative values don’t cause invalid paging behavior, and verifies it with TCK tests.
Changes:
- Clamp SCIM
countto a minimum of0for user and group searches. - Add new pagination tests covering negative
countfor users and groups.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scim/tests/base/src/test/java/org/keycloak/tests/scim/tck/PaginationTest.java | Adds TCK tests asserting behavior when count is negative. |
| scim/model/src/main/java/org/keycloak/scim/model/user/UserResourceTypeProvider.java | Clamps count to >= 0 before applying default max results. |
| scim/model/src/main/java/org/keycloak/scim/model/group/GroupResourceTypeProvider.java | Same clamping logic for group searches. |
ssilvert
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50471