Repository navigation
Stop cookie-based SSO re-auth from resetting brute-force counter (26.6) - #50047
Merged
Merged
Conversation
…cloak#49996) This commit fixes an issue where a SSO re-auth was calling a reset on the brute-force counter, and clearing lockout, allowing a malicious actor to continue brute-forcing as long as the user was logged in and active. Brute-force reset is now only called on a successful login that wasn't a SSO re-auth. It also resets the brute-force counter based on credential categories: only categories defined in the BruteForceProtector under ALLOWED_AUTHENTICATION_CATEGORIES are processed, allowing flexibility on what counts as a valid login attempt. Null-handling in BruteForceProtector was tightened for success and loosened for failure. Closes keycloak#49960 Signed-off-by: Niels Van Nerum <vannerumniels@icloud.com> (cherry picked from commit ed270d9) test
Member
|
@rmartinc Are these changes related to the assigned issues (closes xxx)? |
Contributor
Author
|
@mabartos I copied the other issue 😛, but the PR is OK. I needed to update the test for the changes in the TS framework. I copied the correct links in this PR now. |
ahus1
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49960
PR: #49996
Commit: ed270d9
PR branch: backport-49996-26.6
Target branch: https://github.com/keycloak/keycloak/tree/release/26.6