Skip to content

Remove unused Log4j dependency management - #51409

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
Pepo48:issue-51388
Aug 4, 2026
Merged

Remove unused Log4j dependency management#51409
vmuzikar merged 1 commit into
keycloak:mainfrom
Pepo48:issue-51388

Conversation

@Pepo48

@Pepo48 Pepo48 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Closes #51388

The dependency management was added in #36758 to fix log4j dependencies when running Keycloak from IDE. The same day, IDELauncher in quarkus/server, which had dependencies that could pull in log4j transitively, was removed (#35913) and replaced by org.keycloak.Keycloak in junit5. The replacement already excludes log4j-jboss-logmanager since its creation and no module in the reactor resolves any log4j artifact today.

Closes keycloak#51388

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48
Pepo48 requested a review from a team as a code owner August 3, 2026 20:04
Copilot AI review requested due to automatic review settings August 3, 2026 20:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes obsolete Log4j dependency management after confirming Keycloak no longer resolves these artifacts.

Changes:

  • Removes the unused Log4j version property.
  • Removes managed log4j-api and log4j-core dependencies.

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Pepo48.

@vmuzikar
vmuzikar merged commit 8f070b0 into keycloak:main Aug 4, 2026
94 checks passed
eryx12o45 pushed a commit to eryx12o45/keycloak that referenced this pull request Aug 6, 2026
Closes keycloak#51388

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and potentially remove Log4j dependency management

4 participants