Fix ArrayIndexOutOfBoundsException in SearchQueryUtils.getFields() - #51543
Merged
Conversation
Add bounds checks before accessing chars[i+1] in both field-name and value parsing loops to prevent ArrayIndexOutOfBoundsException on malformed search queries with trailing backslashes. Unterminated escape sequences now throw ModelValidationException with a descriptive message. Closes keycloak#50228 Signed-off-by: Ponshankar <mail4ponz@gmail.com>
Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents malformed search queries with trailing escape characters from causing out-of-bounds access.
Changes:
- Validates escape sequences before accessing the next character.
- Adds regression tests for malformed and boundary-case queries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
SearchQueryUtils.java |
Rejects unterminated escape sequences safely. |
SearchQueryUtilsTest.java |
Covers malformed and boundary inputs. |
pedroigor
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50228