Add Vert.x HTTP client as v2 alternative to Apache HTTP client - #51638
Draft
Pepo48 wants to merge 1 commit into
Draft
Add Vert.x HTTP client as v2 alternative to Apache HTTP client#51638Pepo48 wants to merge 1 commit into
Pepo48 wants to merge 1 commit into
Conversation
Pepo48
force-pushed
the
issue-49968
branch
2 times, most recently
from
August 12, 2026 11:36
e76358c to
10ec835
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#timeout |
Closes keycloak#49968 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test01_ldapOnlyGroupMappings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Vert.x-based HTTP client for outbound connections, opt-in via
--features=http-client:v2. The existing Apache client stays as the default.The Vert.x client shares the same config properties as Apache, switching requires only enabling the feature. It supports TLS (truststore + mTLS), proxy with
NO_PROXY,connection pooling, retries with exponential backoff and OpenSSL detection with a configurable startup policy (warn/fail/none) for future PQC enforcement.For backward compatibility,
getHttpClient()returns a bridge that wraps Vert.x behind Apache'sCloseableHttpClientAPI. Eight direct Apache callers were migrated toSimpleHttp.Edit:
Just for the clarity, here are what I consider to be the next steps (in the given order):
PREVIEWtoDEFAULT.server-spi-private, rewriteSimpleHttpinternals - could be also done as a part of this PR, butSimpleHttplives in a platform-independent module that can't import Vert.x, it would require an execution abstraction that only makes sense after Apache is deprecated.Let me definitely know, whether these make sense as follow-ups.
Closes #49968