Report OID4VCI credential request errors - #51697
Merged
mposolda merged 1 commit intoAug 13, 2026
Merged
Conversation
Treat absent credential claims metadata as an empty claim set so client scopes without protocol mappers can issue credentials. Record proof validation failures on the credential request error event, including the OID4VCI error type and reason. Closes keycloak#51692 Signed-off-by: Shurong Cao <170531907+CAOShurong@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes OID4VCI credential issuance and error-event reporting.
Changes:
- Handles missing credential claims metadata as an empty claim set.
- Records proof-validation errors with their type and reason.
- Adds regression tests for mapper-free scopes and future-
iatproofs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
services/.../OID4VCIssuerEndpoint.java |
Handles absent claims and reports proof errors. |
tests/.../OID4VCJWTIssuerEndpointTest.java |
Adds regression and event assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mposolda
approved these changes
Aug 13, 2026
mposolda
left a comment
Contributor
There was a problem hiding this comment.
@CAOShurong Thanks, I hope to merge if automated tests are OK
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserAuthenticationNoneEncryptionSSLKeycloak CI - Java Distribution IT (windows-latest - temurin - 21) |
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51692.
What changed
VERIFIABLE_CREDENTIAL_REQUEST_ERRORevent, including the OID4VCI error type and the failure reason.iatproof.Verification
OID4VCJWTIssuerEndpointTestclass passes: 55 tests, 0 failures, 0 errors.servicesandtests/baseSpotless checks pass.AI assistance disclosure
I used an AI coding assistant to help investigate the issue, implement the change, and run the verification. I reviewed the resulting diff and test evidence before submitting it.