Passkey icons use wrong color variant when realm disables dark mode by mabartos · Pull Request #51091 · keycloak/keycloak

mabartos · 2026-07-22T13:04:14Z

Closes Passkey icons use wrong color variant when realm disables dark mode #51087

Resolves the issue:

Screencast.From.2026-07-22.14-29-08.mp4

Screencast.From.2026-07-22.14-23-17.mp4

@edewit Could you please check it? I'd like to backport it to 26.7, and I mark the darkMode as required in the environment. I think it should be fine as users always uses the same server version and console versions, right?

Copilot

Pull request overview

Fixes passkey icon selection when dark mode is disabled for a realm.

Changes:

Gates dark passkey icons on the realm’s dark-mode setting.
Exposes darkMode through console environments.
Updates login and Account Console rendering.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`themes/.../webauthn-authenticate.ftl`	Gates the login passkey dark icon.
`js/libs/ui-shared/src/context/environment.ts`	Adds the optional environment setting.
`js/apps/admin-ui/.../index.ftl`	Exposes dark mode to Admin UI.
`js/apps/account-ui/src/account-security/SigningIn.tsx`	Gates Account Console dark icons.
`js/apps/account-ui/.../index.ftl`	Exposes dark mode to Account UI.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2026-07-22T14:00:34Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredAndRegisterClick

Keycloak CI - Forms IT (chrome)

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostSigTest

Keycloak CI - Adapter IT Strict Cookies

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#disabledClientTest

Keycloak CI - Adapter IT Strict Cookies

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for wrapped: text ('Login requester not enabled') to be present in text in element found by By.xpath: //body (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.17.0-1020-azure', java.version: '21.0.11'
Driver info: org.openqa.selenium.firefox.FirefoxDriver_ByGraphene
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#idpInitiatedLoginTest

Keycloak CI - Adapter IT Strict Cookies

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for wrapped: text ('principal=bburke') to be present in text in element found by By.xpath: //body (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.17.0-1020-azure', java.version: '21.0.11'
Driver info: org.openqa.selenium.firefox.FirefoxDriver_ByGraphene
...

Report flaky test

Closes keycloak#51087 Signed-off-by: Martin Bartoš <mabartos@redhat.com>

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2026-07-23T07:01:03Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredAndRegisterClick

Keycloak CI - Forms IT (chrome)

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostSigTest

Keycloak CI - Adapter IT Strict Cookies

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#disabledClientTest

Keycloak CI - Adapter IT Strict Cookies

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for wrapped: text ('Login requester not enabled') to be present in text in element found by By.xpath: //body (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.17.0-1020-azure', java.version: '21.0.11'
Driver info: org.openqa.selenium.firefox.FirefoxDriver_ByGraphene
...

Report flaky test

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#idpInitiatedLoginTest

Keycloak CI - Adapter IT Strict Cookies

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for wrapped: text ('principal=bburke') to be present in text in element found by By.xpath: //body (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.17.0-1020-azure', java.version: '21.0.11'
Driver info: org.openqa.selenium.firefox.FirefoxDriver_ByGraphene
...

Report flaky test

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

js/apps/account-ui/src/account-security/SigningIn.tsx:136

Extend the existing signing-in tests to cover both values of the injected darkMode flag and assert whether this dark <source> is present. Without that regression coverage, the account-console half of #51087 can recur independently of the login template.

                  {context.environment.darkMode && iconDarkSrc && (
                    <source
                      srcSet={iconDarkSrc}
                      media="(prefers-color-scheme: dark)"

mabartos · 2026-07-23T08:46:23Z

  /** The URL to be followed when the logo is clicked. */
  logoUrl: string;
+  /** Whether dark mode is enabled for the realm. */
+  darkMode: boolean;


Hmm, I'm still thinking about this - whether to have it as required or optional. For the admin/account console, it should be fine to have it required as those versions should come up with the same version of the Keycloak server, so there should not be any problem.

Do we use this ui-shared environment even outside these scenarios? Like JS client?

@edewit WDYT? Or should we rather make it optional and be on the safe side? :P

it's fine to have this as a required field, it only shows what fields are injected into the page

@edewit Ok, thanks for the confirmation.

keycloak-github-bot · 2026-07-23T08:05:12Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#testLoginPageRefresh

Keycloak CI - Forms IT (firefox)

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#timeout

Keycloak CI - WebAuthn IT

org.openqa.selenium.WebDriverException: 
unknown error: unhandled inspector error: {"code":-32000,"message":"Node with given id does not belong to the document"}
  (Session info: chrome=150.0.7871.128)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.17.0-1020-azure', java.version: '25.0.3'
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

rmartinc

Thanks @mabartos and @edewit!

Copilot AI review requested due to automatic review settings July 22, 2026 13:04

mabartos requested review from a team as code owners July 22, 2026 13:04

keycloak-github-bot Bot added the team/core-authn label Jul 22, 2026

mabartos requested review from edewit and rmartinc July 22, 2026 13:04

Copilot started reviewing on behalf of mabartos July 22, 2026 13:04 View session

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread js/apps/account-ui/src/account-security/SigningIn.tsx Outdated

keycloak-github-bot Bot added the flaky-test label Jul 22, 2026

keycloak-github-bot Bot reviewed Jul 22, 2026

View reviewed changes

Passkey icons use wrong color variant when realm disables dark mode

53ebb68

Closes keycloak#51087 Signed-off-by: Martin Bartoš <mabartos@redhat.com>

Copilot AI review requested due to automatic review settings July 23, 2026 07:00

mabartos force-pushed the KC-51087 branch from b833eff to 53ebb68 Compare July 23, 2026 07:00

Copilot started reviewing on behalf of mabartos July 23, 2026 07:00 View session

keycloak-github-bot Bot reviewed Jul 23, 2026

View reviewed changes

Copilot AI reviewed Jul 23, 2026

View reviewed changes

edewit approved these changes Jul 23, 2026

View reviewed changes

keycloak-github-bot Bot mentioned this pull request Jul 23, 2026

Flaky test: org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredInTheMiddle #51074

Open

keycloak-github-bot Bot reviewed Jul 23, 2026

View reviewed changes

mabartos self-assigned this Jul 23, 2026

rmartinc approved these changes Jul 23, 2026

View reviewed changes

rmartinc merged commit c50bfbd into keycloak:main Jul 23, 2026
99 of 101 checks passed

Uh oh!

Conversation

mabartos commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented Jul 22, 2026

Unreported flaky test detected

org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredAndRegisterClick

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostSigTest

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#disabledClientTest

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#idpInitiatedLoginTest

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot Bot commented Jul 23, 2026

Unreported flaky test detected

org.keycloak.testsuite.forms.MultipleTabsLoginTest#multipleTabsParallelLoginTestWithAuthSessionExpiredAndRegisterClick

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostSigTest

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#disabledClientTest

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#idpInitiatedLoginTest

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mabartos Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

edewit Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

mabartos Jul 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keycloak-github-bot Bot commented Jul 23, 2026

Unreported flaky test detected

org.keycloak.testsuite.forms.MultipleTabsLoginTest#testLoginPageRefresh

org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#timeout

Uh oh!

keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

rmartinc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mabartos commented Jul 22, 2026 •

edited

Loading