Skip to content

Wait for AUTH_RESPONSE page in MultipleTabsLoginTest #51103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmartinc wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Wait for AUTH_RESPONSE page in MultipleTabsLoginTest #51103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...quillian/tests/base/src/test/java/org/keycloak/testsuite/forms/MultipleTabsLoginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import org.keycloak.testsuite.util.BrowserTabUtil;
import org.keycloak.testsuite.util.InfinispanTestTimeServiceRule;
import org.keycloak.testsuite.util.MailServer;
import org.keycloak.testsuite.util.UIUtils;
import org.keycloak.testsuite.util.WaitUtils;
import org.keycloak.testsuite.util.oauth.AccessTokenResponse;
import org.keycloak.testsuite.util.oauth.AuthorizationEndpointResponse;
Expand Down Expand Up @@ -341,7 +342,6 @@ public void multipleTabsParallelLoginTestWithAuthSessionExpiredAndResetPasswordC
multipleTabsParallelLogin(tabUtil);

waitForAppPage(() -> loginPage.resetPassword());
WaitUtils.waitForPageToLoad();
Assertions.assertTrue(oauth.parseLoginResponse().isError());
events.skip(4);
assertOnAppPageWithAlreadyLoggedInError(EventType.RESET_PASSWORD_ERROR);
Expand Down Expand Up @@ -426,9 +426,7 @@ public void multipleTabsParallelLoginTestWithAuthSessionExpiredAndRefreshInTab1(
tabUtil.closeTab(1);
assertThat(tabUtil.getCountOfTabs(), Matchers.equalTo(1));

waitForAppPage(() -> {
driver.navigate().refresh();
});
waitForAppPage(() -> driver.navigate().refresh());
Assertions.assertTrue(oauth.parseLoginResponse().isError());
events.skip(6);
assertOnAppPageWithAlreadyLoggedInError(EventType.LOGIN_ERROR);
Expand Down Expand Up @@ -1088,5 +1086,6 @@ private void waitForAppPage(Runnable htmlUnitAction) {
// error and being redirected to client
htmlUnitAction.run();
}
UIUtils.currentTitleEquals("AUTH_RESPONSE");

@gaoyikeshuer gaoyikeshuer Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, just noticed the currentTitleEquals method will return to boolean value and swallows the timeout exception. so its a wait rather than check. since we want to resolve the flaky issues, should we assert on the result with some message? LGTM otherwise also

@rmartinc rmartinc Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fails and returns false, we will get the error we are trying to fix. So I think that no issue. I just used this method to not create a new one that waits for the auth response page. Thanks!

}
}
Loading