Repository navigation
Do not log ABCA client authentication headers - #53484
Merged
mposolda merged 1 commit intoNov 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused deletion removes credential exposure without changing validation or control flow.
Review effort: Balanced
Findings: None
What changed in this PR
Addresses #52508 by removing DEBUG logging of ABCA client credentials without changing authentication behavior.
Changes:
- Removes both log statements that expose signed attestation headers and misuse
debugfformat strings.
| File | Description |
|---|---|
| services/src/main/java/org/keycloak/authentication/authenticators/client/AttestationBasedClientAuthenticator.java | Removes credential-bearing DEBUG logs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The Attestation-Based Client Authenticator wrote the full OAuth-Client-Attestation and OAuth-Client-Attestation-PoP header values to the DEBUG log before validating them. These are signed JWTs used as client credentials, so remove those statements. Closes keycloak#52508 Signed-off-by: wakqasahmed <wakqasahmed@gmail.com>
mposolda
force-pushed
the
fix/issue-52508-abca-no-header-logging
branch
from
November 5, 2026 11:01
22560b4 to
f76286b
Compare
mposolda
approved these changes
Nov 5, 2026
Contributor
|
@wakqasahmed @dominikschlosser Thanks for the PR and review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52508
AttestationBasedClientAuthenticator.authenticateClient()logged the fullOAuth-Client-AttestationandOAuth-Client-Attestation-PoPheader values at DEBUG before validating them. Those are signed JWTs used as client credentials, so anyone with access to DEBUG logs could lift a working pair. The values were also concatenated into thedebugfformat string, which is a format-string misuse on its own.This removes the two log statements. I didn't replace them with a metadata log: the
subandjtisuggested in the issue are only available after the JWTs are parsed, and the validation code that does that already reports failures throughServicesLogger.LOGGER.errorValidatingAssertion. Happy to add a post-validationsub/jtidebug line if you'd prefer one.Same idea as #53395 for the SPNEGO token. The similar logging in the OID4VCI code (#52509) is left for a separate change.
I did not add a test: asserting on server DEBUG output would need a full integration run for a pure deletion of two statements, and I couldn't build the services module on my machine, so I'm relying on CI for the compile.
I used an AI agent (Claude Code) to help with this change.