Repository navigation
Conversation
Closes keycloak#54504 Signed-off-by: gibKim <gbkim0909@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the partial component update fix.
No open issues 🎉
What changed in this PR
Fixes partial component updates that return HTTP 500 when provider metadata is omitted, addressing #54504 while preserving configuration merging and admin-event secret masking.
Changes:
- Fills missing provider fields from the merged component before generating the admin event.
- Adds regression coverage for omitted provider fields and configuration, retained values, and secret masking.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/admin/ComponentsTest.java |
Tests partial updates, configuration retention, and admin-event secret masking. |
services/src/main/java/org/keycloak/services/resources/admin/ComponentResource.java |
Supplies omitted provider metadata before admin-event generation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54504
Decisions and assumptions:
An AI agent generated the implementation and tests.