Repository navigation
Conversation
Closes keycloak#55152 Signed-off-by: IshanKale <keshavraokale6@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to treat release branch suffixes as literal strings in CI release filtering.
No open issues 🎉
What changed in this PR
This PR addresses #55152 by treating release branch suffixes as literal data when filtering releases for the CI compatibility matrix.
Changes:
- Adds
--to prevent suffixes beginning with-from being parsed asgrepoptions. - Uses
-Fto preserve substring matching without interpreting regular-expression characters.
| File | Description |
|---|---|
.github/scripts/version-compatibility.sh |
Uses fixed-string matching and an option delimiter when filtering release names. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55152
Release branch suffixes are Git ref text and must be matched as data. Fixed-string matching preserves the intended substring filter, while the option delimiter prevents valid names beginning with
-from changinggrepbehavior.Tested with a deterministic
gh release liststub:release/26.1returned the expected release;release/-f...andrelease/--file=...both safely returnedskip.AI disclosure: Codex assisted with this change. I reviewed and understand the final one-line patch.