Skip to content

Prevent grep option parsing in version compatibility - #55182

Open
IshanKale wants to merge 1 commit into
keycloak:mainfrom
IshanKale:fix/version-compatibility-grep
Open

IshanKale wants to merge 1 commit into
keycloak:mainfrom
IshanKale:fix/version-compatibility-grep

Conversation

@IshanKale

Copy link
Copy Markdown

Closes #55152

Release branch suffixes are Git ref text and must be matched as data. Fixed-string matching preserves the intended substring filter, while the option delimiter prevents valid names beginning with - from changing grep behavior.

Tested with a deterministic gh release list stub: release/26.1 returned the expected release; release/-f... and release/--file=... both safely returned skip.

AI disclosure: Codex assisted with this change. I reviewed and understand the final one-line patch.

Closes keycloak#55152

Signed-off-by: IshanKale <keshavraokale6@gmail.com>
@IshanKale
IshanKale requested a review from a team as a code owner November 14, 2026 07:30
Copilot AI balanced review requested due to automatic review settings November 14, 2026 07:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change to treat release branch suffixes as literal strings in CI release filtering.

No open issues 🎉

What changed in this PR

This PR addresses #55152 by treating release branch suffixes as literal data when filtering releases for the CI compatibility matrix.

Changes:

  • Adds -- to prevent suffixes beginning with - from being parsed as grep options.
  • Uses -F to preserve substring matching without interpreting regular-expression characters.
File Description
.github/​scripts/​version-compatibility.sh Uses fixed-string matching and an option delimiter when filtering release names.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: release branch names are interpreted as grep options in version-compatibility.sh

2 participants