Repository navigation
Conversation
Closes keycloak#55184 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the Azure SQL initialization changes.
No open issues 🎉
What changed in this PR
Updates Azure SQL CI initialization so GitHub-hosted runners outside Azure can connect during database setup.
Changes:
- Detect and validate the runner’s public IPv4 address.
- Add and remove a temporary Azure SQL firewall rule for the runner.
- Replace server-state polling with SQL connectivity retries.
| File | Description |
|---|---|
| .github/scripts/azure/sql/azure_create_sql.sh | Adds runner IP detection, temporary firewall-rule management, SQL connectivity retries, and cleanup during Azure SQL initialization. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55184
The proof that connection now works from an AWS-hosted runner (us-east-1, 3.41.210.69): https://github.com/Pepo48/keycloak/actions/runs/43607842254/job/132486414550