Repository navigation
[Quarkus 4] Use entity types in criteria joins - #55198
Merged
Merged
Conversation
Closes: keycloak#55197 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified, and the changes consistently align the Criteria joins with their mapped entity and map types.
No open issues 🎉
What changed in this PR
Updates JPA Criteria API join declarations to use the concrete entity and map types defined by the corresponding entity mappings, aligning the code with Jakarta Persistence 4 without changing query behavior.
Changes:
- Typed the user federated-identity join with
UserEntityandFederatedIdentityEntity. - Typed policy scope, configuration, and associated-policy joins with their mapped entity and map types.
- Added the required
ScopeEntityimport.
| File | Description |
|---|---|
| model/jpa/src/main/java/org/keycloak/models/jpa/JpaUserProvider.java | Uses concrete entity types for the user-to-federated-identity Criteria join. |
| model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAPolicyStore.java | Uses concrete entity and map key/value types for policy Criteria joins. |
Review effort: Lite
16 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #55197
This can land directly in main - all join types match their entity mappings, including Map<String, String> configuration,
join names, join types, predicates and query execution remain unchanged.