Repository navigation
Conversation
Explain automatic and manual migration differences, precondition handling, persisted history, deferred indexes, custom changes, and validation. Add an agent skill that applies the same review workflow. Closes keycloak#55057 Signed-off-by: IshanKale <keshavraokale6@gmail.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for this documentation-only update to Liquibase changelog guidance.
No open issues 🎉
What changed in this PR
This documentation-only PR addresses #55057 by explaining how Keycloak Liquibase changelogs should support both automatic migration and manual SQL generation.
Changes:
- Documents precondition handling, persisted changeset history, deferred indexes, index replacement, and custom Java changes.
- Adds guidance on schema parity checks and database migration tests.
- Introduces a reusable skill for creating and reviewing changelogs using these practices.
| File | Description |
|---|---|
skills/kc-database-changelog/SKILL.md |
Adds a changelog creation and review workflow with validation checks. |
docs/updating-database-schema.md |
Expands migration guidance with execution-mode differences, reference patterns, and testing pointers. |
Review effort: Balanced
ahus1
removed their request for review
November 17, 2026 11:02
Member
|
@shawkins - I'm removing myself as a reviewer for now as you have the best knowledge from the previous PR how things should work. I can do a second review after that with my noob eyes to spot items that need additions in the docs. Please re-add me once I should do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55057
This extends the database schema documentation with guidance for automatic and manual Liquibase migrations, including
onSqlOutput, persisted changeset history, deferred indexes, index replacement, custom Java changes, and migration validation.It also adds a repository skill for creating and reviewing database changelogs using the same practices.
Validation:
git diff --checkpassed