You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use the realm name matched in the request so admin-event resource paths stay relative to the realm when a case-insensitive database accepts different casing. Shared extraction preserves the casing of decoded resource names and IDs in both API versions and keeps unmatched paths intact.
The regressions invoke the builders in real server sessions with the resolved realm model, so they also run on case-sensitive databases. They cover both URI overloads, decoded paths and trailing slashes; the admin-event documentation now describes the path semantics.
Validation on Windows with JDK 17, the distribution server and H2 (dev-mem): AdminEventTest passed 15 tests and AdminEventV2Test passed 7, with no failures or skips. Before the fix, both mixed-case regressions failed while their same-case controls passed. mvnw.cmd -Pspotless spotless:apply and mvnw.cmd -Pspotless spotless:check passed.
AI assistance: Codex generated the implementation, regression tests and documentation.
Use the realm matched in the request to derive resource paths for both Admin API versions.
Closeskeycloak#55222
Signed-off-by: Nash Aschenbath <wwh86696@163.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Both admin event tests misidentify the remote MSSQL configuration, causing them to expect 404 instead of valid success responses and fail the Azure database job.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The test fails incorrectly on case-insensitive remote databases such as MSSQL because it checks the supplier name rather than the vendor, expecting 404 instead of 201.
With kc.test.database=remote and a case-insensitive vendor such as mssql, this returns remote, so the mixed-case request succeeds with 201 but the test incorrectly expects 404. Resolve kc.test.database.vendor for the remote supplier, as the v1 regression already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the realm name matched in the request so admin-event resource paths stay relative to the realm when a case-insensitive database accepts different casing. Shared extraction preserves the casing of decoded resource names and IDs in both API versions and keeps unmatched paths intact.
The regressions invoke the builders in real server sessions with the resolved realm model, so they also run on case-sensitive databases. They cover both URI overloads, decoded paths and trailing slashes; the admin-event documentation now describes the path semantics.
Closes #55222
Validation on Windows with JDK 17, the distribution server and H2 (
dev-mem):AdminEventTestpassed 15 tests andAdminEventV2Testpassed 7, with no failures or skips. Before the fix, both mixed-case regressions failed while their same-case controls passed.mvnw.cmd -Pspotless spotless:applyandmvnw.cmd -Pspotless spotless:checkpassed.AI assistance: Codex generated the implementation, regression tests and documentation.