[KEYCLOAK-11719] - Remove need for servlets/undertow from Quarkus dist#7063
Merged
stianst merged 1 commit intokeycloak:masterfrom May 13, 2020
Merged
[KEYCLOAK-11719] - Remove need for servlets/undertow from Quarkus dist#7063stianst merged 1 commit intokeycloak:masterfrom
stianst merged 1 commit intokeycloak:masterfrom
Conversation
Co-authored-by: MatthewC <matthewc@backbase.com>
stianst
approved these changes
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #6600, from @jonm-bb.
In addition to changes from that PR, this one includes:
keycloak-services. We should not be using it but favoring Resteasy APIs.KeycloakSessionServletFiltertokeycloak-wildfly-extensionsas well as to testsuite (as a consequence of initial #1 above).We could replace
KeycloakSessionServletFilter(using Servlet API) with a Resteasy request/response filter, just like we are doing for Quarkus. However, I didn't want to change for the main distribution before we are sure that the Resteasy filters work as expected. If you think we can just use it, I'm OK to have the same filter across all platforms (Wildfly, Quarkus, and Test).