KEYCLOAK-15985 Brute Force Detection Lockout Event#7704
Closed
Victor-Philipp-Negoescu wants to merge 1 commit into
Closed
KEYCLOAK-15985 Brute Force Detection Lockout Event#7704Victor-Philipp-Negoescu wants to merge 1 commit into
Victor-Philipp-Negoescu wants to merge 1 commit into
Conversation
d72c6ce to
b5ddfd7
Compare
Contributor
|
@Victor-Philipp-Negoescu I haven't noticed your PR was still open. I made another one #8679 that includes the test. It would be great if someone could review my PR. We might close this one once mine has been reviewed. |
Contributor
|
Closing due to lack of tests, and there's a follow-up PR with tests included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new "USER_LOCKED" event is introduced that is fired whenever the DefaultBruteForceDetector locks a user.
Please review the PR and tell me where I can provide unit/integration tests. So far I could not find any tests that are related to the brute-force detector.