Can anyone please review this MR?

@abstractj this PR seem a fairly decent improvement around visibility of lockout events. Would any of the devs be able to review and merge?

Bump! Would love to see this improvement.

Thanks @trixpan, as soon as the @keycloak/core has some bandwidth to review, they will do.

@paulbares If you rebase your PR and look at the remaining comment from me, we can then move forward with it.

@pedroigor I have made the changes and rebased my PR.

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.example.cors.CorsExampleAdapterTest#angularCorsProductTest

Keycloak CI - Base IT (2)

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for text ('iphone') to be present in text ('') in element GrapheneElement -> [[ChromeDriver: chrome on LINUX (24e4fe53a0ef8c5a91e74fdaf1562e02)] -> id: output] (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az400-887', ip: '10.1.0.115', os.name: 'Linux', os.arch: 'amd64', os.version: '6.2.0-1011-azure', java.version: '17.0.8.1'
Driver info: org.openqa.selenium.chrome.ChromeDriver$$EnhancerByGraphene$$e86d43e1
...

Report flaky test

Great to see it merged, thank you @pedroigor for the review.

3 flaky tests on run #8968 ↗︎

0

1054

96

0

3

Details:

  clients_test.spec.ts • 1 flaky test • firefox

View Output Video

Test		Artifacts
Clients test > Advanced tab test > Clustering		Output Screenshots

  realm_settings_client_profiles_test.spec.ts • 1 flaky test • firefox

View Output Video

Test		Artifacts
Realm settings client profiles tab tests > Should not create duplicate client profile		Output Screenshots

  masthead_test.spec.ts • 1 flaky test • firefox

View Output Video

Test		Artifacts
Masthead tests > Desktop view > Go to account console and back to admin console		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}