[KEYCLOAK-18630] - Request object encryption support#8243
Merged
Conversation
pedroigor
force-pushed
the
KEYCLOAK-18630
branch
4 times, most recently
from
July 6, 2021 12:49
bacb773 to
77d98fd
Compare
pedroigor
force-pushed
the
KEYCLOAK-18630
branch
2 times, most recently
from
July 6, 2021 18:43
594b579 to
6e3c9d8
Compare
mposolda
requested changes
Jul 9, 2021
mposolda
left a comment
Contributor
There was a problem hiding this comment.
@pedroigor Thanks Pedro for the PR!
I've added two inline comments (possibly discussion points) to the PR.
mposolda
approved these changes
Jul 9, 2021
mposolda
left a comment
Contributor
There was a problem hiding this comment.
@pedroigor Thanks Pedro! I am approving. I hope we can merge once tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically:
kidor on the priority set for keys in case multipleENCkeys exist and nokidwas setRSA-OAEPandRSA-OAEP-256algorithms. As well as content encryption usingA256GCM.TokenManagerto deal with bothJWSandJWE. It should make it easier to support encryption in other places where clients might send JWS/JWE.I did not include yet any config option for clients like to force encryption for request objects or even force a specific alg/enc.