Skip to content
This repository was archived by the owner on Nov 16, 2022. It is now read-only.

KEYCLOAK-12273 Keycloak Operator documentation #108

Merged
slaskawi merged 1 commit into from
Aug 17, 2020
Merged

KEYCLOAK-12273 Keycloak Operator documentation #108

slaskawi merged 1 commit into from
Aug 17, 2020

Conversation

@slaskawi
Copy link
Contributor

@slaskawi slaskawi commented Dec 6, 2019

JIRA ID

KEYCLOAK-12273

Additional Information

Verification Steps

Checklist:

  • Verified by team member
  • Comments where necessary
  • Automated Tests
  • Documentation changes if necessary

Additional Notes

@slaskawi
Copy link
Contributor Author

slaskawi commented Dec 6, 2019

Please merge this one after keycloak/keycloak-documentation#796

@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 43.905% when pulling 004990a on slaskawi:KEYCLOAK-12273-Keycloak-Operator-documentation into 5831169 on keycloak:master.

@abstractj abstractj self-assigned this Jan 6, 2020
@abstractj abstractj added the Hold label Jan 7, 2020
@abstractj
Copy link
Contributor

abstractj commented Jan 7, 2020

Just added a label to prevent accidental merge, until we get keycloak/keycloak-documentation#796 merged.

@abstractj abstractj self-requested a review January 7, 2020 14:11
@slaskawi slaskawi mentioned this pull request Jan 13, 2020
Merged
4 tasks
@slaskawi slaskawi removed the request for review from abstractj April 9, 2020 07:23
@slaskawi slaskawi removed the Hold label Apr 9, 2020
@slaskawi slaskawi modified the milestones: 10.0.0, 9.0.3 Apr 9, 2020
@slaskawi slaskawi force-pushed the KEYCLOAK-12273-Keycloak-Operator-documentation branch from 6326ce5 to 2c963d7 Compare April 23, 2020 10:35
@slaskawi slaskawi added the Hold label Apr 23, 2020
@slaskawi slaskawi force-pushed the KEYCLOAK-12273-Keycloak-Operator-documentation branch from 2c963d7 to 004990a Compare June 19, 2020 07:03
@slaskawi slaskawi removed the Hold label Jun 19, 2020
@slaskawi slaskawi removed this from the 9.0.3 milestone Jun 19, 2020
mhajas
mhajas previously approved these changes Jun 19, 2020
View reviewed changes
stianst
stianst previously approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stianst stianst added the Hold label Jun 19, 2020
@abstractj
Copy link
Contributor

abstractj commented Jun 19, 2020

@stianst @slaskawi shall we keep this on hold?

@abstractj abstractj self-assigned this Jun 19, 2020
@slaskawi
Copy link
Contributor Author

slaskawi commented Jun 22, 2020

@abstractj Yes, that's a good point. Currently the documentation is not yet visible (although it has already been pushed to master). Let's wait till 11 is out.

@slaskawi slaskawi added this to the 11.0.0 milestone Jun 22, 2020
@slaskawi slaskawi dismissed stale reviews from stianst and mhajas via 12f6d7f August 10, 2020 12:41
@slaskawi slaskawi force-pushed the KEYCLOAK-12273-Keycloak-Operator-documentation branch from 004990a to 12f6d7f Compare August 10, 2020 12:41
@slaskawi slaskawi requested review from mhajas and stianst August 10, 2020 12:42
@slaskawi slaskawi removed this from the 11.0.0 milestone Aug 10, 2020
@slaskawi
Copy link
Contributor Author

slaskawi commented Aug 10, 2020

I rebased this one. Ready to be reviewed @vmuzikar @ASzc @abstractj

mhajas
mhajas previously approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @slaskawi! This is really useful for anyone who starts with keycloak-operator.

Just an idea of enhancement, do you think you would be able to add steps on how to debug e2e tests from Goland/vscode? I was able to do it in Goland, but I lost it, unfortunately. I remember I needed to put some of the arguments from here: https://github.com/keycloak/keycloak-operator/blob/master/Makefile#L60 to program arguments and some to Go tool arguments. I can try to investigate it more if you want.

@slaskawi
Copy link
Contributor Author

slaskawi commented Aug 10, 2020

Just an idea of enhancement, do you think you would be able to add steps on how to debug e2e tests from Goland/vscode? I was able to do it in Goland, but I lost it, unfortunately. I remember I needed to put some of the arguments from here: https://github.com/keycloak/keycloak-operator/blob/master/Makefile#L60 to program arguments and some to Go tool arguments. I can try to investigate it more if you want.

@mhajas I would be very interested in this myself. I haven't done this before and I've been using logging to debug e2e tests. I hope you'll find your notes and share it :) It would be great to plug the debugger in during the tests :)

vmuzikar
vmuzikar previously approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell looks good to me. Thanks @slaskawi!

@slaskawi slaskawi dismissed stale reviews from vmuzikar and mhajas via 40e11be August 11, 2020 06:20
@slaskawi slaskawi force-pushed the KEYCLOAK-12273-Keycloak-Operator-documentation branch from 12f6d7f to 40e11be Compare August 11, 2020 06:20
@slaskawi
Copy link
Contributor Author

slaskawi commented Aug 11, 2020

@mhajas @vmuzikar @abstractj Added an information how to debug e2e tests from @mhajas (good stuff!).

mhajas
mhajas approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slaskawi Thanks for the addition! LGTM!

@slaskawi
Copy link
Contributor Author

slaskawi commented Aug 11, 2020

@abstractj Could you please review it and merge it?

@abstractj abstractj requested review from ASzc and mhajas and removed request for ASzc, hmlnarik and pskopek August 12, 2020 17:44
@abstractj
Copy link
Contributor

abstractj commented Aug 12, 2020

@slaskawi LGTM

@slaskawi slaskawi merged commit 7da7404 into keycloak:master Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stianst stianst Awaiting requested review from stianst

@mhajas mhajas Awaiting requested review from mhajas

2 more reviewers

@abstractj abstractj abstractj approved these changes

@vmuzikar vmuzikar vmuzikar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@abstractj abstractj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slaskawi @coveralls @abstractj @stianst @mhajas @vmuzikar