Skip to content
This repository was archived by the owner on Nov 16, 2022. It is now read-only.

Conversation

@ckaserer
Copy link
Contributor

JIRA ID

No Jira ID - updated documentation README.asciidoc

Additional Information

Verification Steps

Check out docs/README.asciidoc

Checklist:

  • Verified by team member
  • Comments where necessary
  • Automated Tests
  • Documentation changes if necessary

Additional Notes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.962% when pulling 8d12ae4 on ckaserer:master into 70f3e5d on keycloak:master.

@slaskawi
Copy link
Contributor

Thanks for the Pull Request @ckaserer !

Just to give you some more context - I'm in the process of moving whole documentation to keycloak-documentation repo - see keycloak/keycloak-documentation#796

Once that PR gets merged, my plan is to integrate #108, that removed most of the documentation from this repo.

So having this in mind, would you still want to integrate this Pull Request?

@ckaserer
Copy link
Contributor Author

Good move consolidating the keycloak doc and the operator doc in a central repo. I appreciate the heads up before I contribute more docs.

I'll wait with further doc pull request until keycloak/keycloak-documentation#796 is through. Once it is done, I'll check, where I can contribute to the operator part of the keycloak-documentation repo. I find it best to start contributing with docs to get to know the components and lingo.

For now, I think it still might be a good idea to put my PR through. It's not much, but the Documentation is already done and others might benefit from it while your pull request is not merged. On the other hand, if you know, that your pull request will go through soon, then it might not be relevant to merge this pull request.

Either way, no hard feelings if you decide to reject this PR. I know the reason and how to contribute to the right repo next time around ;)

Copy link
Contributor

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. Proposed changes look good to me.

@stianst @abstractj This one is ready to be merged.

@abstractj abstractj merged commit 5fbdc14 into keycloak:master Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants