[4/4] Enforce per-session mount security transactions - #20
Merged
khr898 merged 9 commits intoAug 16, 2026
Merged
Conversation
This was referenced Aug 12, 2026
BinaryBearsLLC
force-pushed
the
upstream-pr/4of4-live-security
branch
from
August 12, 2026 08:52
6ef1d6b to
2f7e509
Compare
khr898
marked this pull request as ready for review
August 16, 2026 08:18
khr898
added a commit
that referenced
this pull request
Sep 15, 2026
…rity [4/4] Enforce per-session mount security transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review status and dependency
Important
This is 4 of 4 in an ordered series and depends on #19, #18, and #17. It is intentionally a draft.
The branch is cumulative so the final application can be built and tested as one coherent candidate. It must not be merged out of order. After each predecessor is accepted, this PR will be refreshed from the maintainer-accepted
maintree and the final gates will be rerun before it is marked ready.Summary
This final PR hardens installation, discovery, external-unmount recovery, and privileged PF/VPN cleanup around a per-mount security transaction.
Its relative contribution after #19:
Motivation and root causes
Installed runtime replacement
Replacing a signed helper or runtime file in place can leave a partially written or signature-invalid executable if installation is interrupted. The installed destination should only change after a complete staged replacement has been validated.
Discovery and external unmounts
Drive/filesystem discovery used independent subprocess probes that could compound latency. Separately, Finder or command-line unmounts can remove the kernel mount without passing through the app's normal teardown path, leaving backend/PF/route cleanup pending. The GUI must reflect kernel truth promptly while retaining enough state to retry owned cleanup.
PF/VPN ownership
PF enablement, child anchors, and VPN-bypass routes are host-global facilities shared by potentially concurrent mounts and unrelated software. Cleanup cannot safely flush broad PF state, delete a default route, or release another active mount's resources. Each mount therefore needs explicit ownership plus measured effective-state checks before it can be reported ready.
Implementation
Atomic signed-runtime installation
Combined discovery and external teardown
Per-session security transaction
Evidence boundaries
unknownuntil the reason-coded transaction evidence is wired into that presentation. Lower-layer enforcement is tested, but the UI does not manufacture a green claim.Compatibility and safety
soft; no SMB, loopback fallback, orhardmount is introduced.ntfs-3gremains the default filesystem driver;ntfs3remains opt-in.Verified testing
Validated on the exact submitted cumulative tip
2f7e509e90192e84afc4bd290f9a9ea714942fe4:.commandfiled9b7b53ef03dc8965233e0ccbb242fbc0d90ee8004c1e0459697db059c898e6aorigin/devreferencesrange-diffconfirmed all five relative commits are patch-equivalent to the originally reviewed series; the only inherited tree change is the deterministic predecessor testHardware evidence and remaining gates
The packaged NTFS/VPN-on transaction path has recorded hardware evidence. That evidence does not close the full release matrix.
The following scenarios remain explicit release gates and must be rerun on the refreshed final candidate:
Series order