Conversation
- Added unittest for the fix
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
Zen-CODE
reviewed
Oct 19, 2025
|
|
||
| @pytest.fixture(autouse=True, scope="function") | ||
| def setup(self): | ||
| self.settingNumeric = SettingNumericTest(self.panel) |
Member
There was a problem hiding this comment.
I am concerned here. You are actually testing a subclass of SettingNumeric, not an instance of SettingNumeric itself. You've added a bunch of properties which could interfere with it's behaviour. Even if not now, it could in future versions. Rather build the test to test a pure SettingNumeric instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for the issue #9095
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.