feat: implement window toggle functionality for hyprkcs overlay - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience when launching the
hyprkcsoverlay by making repeated launches toggle the overlay closed, providing a more intuitive and keyboard-friendly way to dismiss it. Additionally, the code is refactored for clarity and reliability, and new unit tests are added to ensure the correct activation behavior.User experience improvements:
hyprkcswhile it is already open now toggles (closes) the existing overlay, making dismissal easier without relying on compositor-specific behavior. (README.md)Code refactoring and reliability:
ActivationActionenum and theactivation_actionfunction to clearly distinguish between building a new window and closing an existing one, improving code clarity and maintainability. (src/ui/window.rs)Testing:
src/ui/window.rs)Fixing issue #74