Skip to content

IJ plugin and Framework shared module - #5908

Open
alfonsoristorato wants to merge 9 commits into
masterfrom
alfonsoristorato/plugin-and-framework-shared-module
Open

alfonsoristorato wants to merge 9 commits into
masterfrom
alfonsoristorato/plugin-and-framework-shared-module

Conversation

@alfonsoristorato

@alfonsoristorato alfonsoristorato commented Apr 14, 2026

Copy link
Copy Markdown
Member

This is an initial attempt at creating a shared module of code that is used by both the plugin and framework.
It starts very simple by exposing a normalizeTestName method and some data test utils constants to test the waters, if this is the way to go, we can slowly add more shared code onto it

@alfonsoristorato
alfonsoristorato requested a review from a team as a code owner April 14, 2026 21:14
@alfonsoristorato
alfonsoristorato marked this pull request as draft April 14, 2026 21:16
@alfonsoristorato

Copy link
Copy Markdown
Member Author

I am only playing around for now :) this has not yet been tested, nor do I know whether implementing our own modules is something that could work for a library

@sksamuel

Copy link
Copy Markdown
Member

I am only playing around for now :) this has not yet been tested, nor do I know whether implementing our own modules is something that could work for a library

I'm not sure if the intellij plugin will include it inside the zip or if it expects it to be in maven central already?

@alfonsoristorato

Copy link
Copy Markdown
Member Author

I am only playing around for now :) this has not yet been tested, nor do I know whether implementing our own modules is something that could work for a library

I'm not sure if the intellij plugin will include it inside the zip or if it expects it to be in maven central already?

ah good point, no it won't find it - let me see what I can do :)

@alfonsoristorato
alfonsoristorato marked this pull request as ready for review April 19, 2026 09:42
@alfonsoristorato

alfonsoristorato commented Apr 19, 2026

Copy link
Copy Markdown
Member Author

What I have (import the srcDir and compile) works, however, should any module that imports this bridge (framework and plugin at the moment) ever be imported in another module that would also import this bridge, we would end up with re-declarations - very big ifs here, but it kinda bothers me - still looking for a better way 😄

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants