Skip to content

Add light and dark to the macOS title bar option - #4378

Merged
kovidgoyal merged 1 commit into
kovidgoyal:masterfrom
page-down:feat-macos-titlebar-opt
Dec 21, 2021
Merged

kovidgoyal merged 1 commit into
kovidgoyal:masterfrom
page-down:feat-macos-titlebar-opt

Conversation

@page-down

Copy link
Copy Markdown
Contributor

Support for explicitly setting the window title bar style for macOS.

When the system appearance of macOS is set to Auto, you can set the appearance of kitty to a fixed Light or Dark.

@kovidgoyal

Copy link
Copy Markdown
Owner

What's the use case for this? Why would you want kitty to use a different color scheme than the rest of the system?

@page-down

Copy link
Copy Markdown
Contributor Author

Because I generally use dark themes in kitty.
This will keep the title bar of the window dark as well, but it doesn't need to be set to the background color.
It is consistent with users's kitty theme (dark, or light) and does not need to be consistent with the whole system.

@kovidgoyal
kovidgoyal merged commit 10e0077 into kovidgoyal:master Dec 21, 2021
@page-down
page-down deleted the feat-macos-titlebar-opt branch December 21, 2021 08:13
@page-down

page-down commented Dec 21, 2021

Copy link
Copy Markdown
Contributor Author

Talking about themes, do you have more considerations for compatibility between version upgrades and themes?

For example using a higher version of a theme on a lower version kitty. Since themes don't have version numbers, when the theme and kitty's version does not match, kitty will report an error for using an unsupported option.

As far as I know, kitten themes will be pulling the latest kitty-themes from GitHub, and after the new version is released, older versions of kitty will probably pull new themes that use the new options.

I'm still holding visual_bell_color and may add it to the kitty-themes template when the new version is released.

@kovidgoyal

kovidgoyal commented Dec 21, 2021 via email

Copy link
Copy Markdown
Owner

@page-down

Copy link
Copy Markdown
Contributor Author

Not something I care enough about. Errors in the conf file are reported
to STDERR IIRC and can simply be ignored.

That's what I thought before, it's not worth putting too much effort into error handling for options.

However this option is a bit different, the error is shown in the overlay. Maybe I should do something about that and have it reported in stderr.

Errors parsing configuration

In file <override>:
1:Invalid color name: dark in line: macos_titlebar_color dark

Press Enter to close.

Feel free to add it now. Unrecognized keys in the conf file are a very
small problem indeed.

Thanks. Then I'll stop worrying about that.

@kovidgoyal

kovidgoyal commented Dec 21, 2021 via email

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants