Add light and dark to the macOS title bar option - #4378
Conversation
|
What's the use case for this? Why would you want kitty to use a different color scheme than the rest of the system? |
|
Because I generally use dark themes in kitty. |
|
Talking about themes, do you have more considerations for compatibility between version upgrades and themes? For example using a higher version of a theme on a lower version kitty. Since themes don't have version numbers, when the theme and kitty's version does not match, kitty will report an error for using an unsupported option. As far as I know, kitten themes will be pulling the latest kitty-themes from GitHub, and after the new version is released, older versions of kitty will probably pull new themes that use the new options. I'm still holding |
|
On Tue, Dec 21, 2021 at 12:34:17AM -0800, page-down wrote:
Talking about themes, do you have more considerations for compatibility between version upgrades and themes?
For example using a higher version of a theme on a lower version. Since themes don't have version numbers, kitty will report an error on version mismatch if a new configuration option is used in it.
Not something I care enough about. Errors in the conf file are reported
to STDERR IIRC and can simply be ignored.
As far as I know, kitten themes will be pulling the latest kitty-themes from GitHub, and after the new version is released, older versions of kitty will probably pull new themes that use the new options.
I'm still holding `visual_bell_color` and may add it to the kitty-themes template when the new version is released.
Feel free to add it now. Unrecognized keys in the conf file are a very
small problem indeed.
|
That's what I thought before, it's not worth putting too much effort into error handling for options. However this option is a bit different, the error is shown in the overlay. Maybe I should do something about that and have it reported in stderr.
Thanks. Then I'll stop worrying about that. |
|
On Tue, Dec 21, 2021 at 12:44:39AM -0800, page-down wrote:
> Not something I care enough about. Errors in the conf file are reported
> to STDERR IIRC and can simply be ignored.
That's what I thought before, it's not worth putting too much effort into error handling for options.
However this option is a bit different, the error is shown in the overlay. Maybe I should do something about that and have it reported in stderr.
Yes just change the parse function to catch the error and report to
stderr and return default value.
|
Support for explicitly setting the window title bar style for macOS.
When the system appearance of macOS is set to Auto, you can set the appearance of kitty to a fixed Light or Dark.