Track mouse events outside the window - #624
dcolascione wants to merge 1 commit into
Conversation
On mouse down, there's an "implicit grab" made by the window system which ensures that mouse events are delivered to the window that received the mouse-down even if the cursor strays outside the original window before mouse-up. Kitty has been filtering out these outside-window events and ignoring them, creating behavior that differs from most other applications. This change remembers the window bound to the mouse-down event and uses it until mouse up, implementing more conventional moues behavior.
|
Just curious, what is the status on this PR? |
|
It's waiting for the changes I indicated in my review. Apparently @dcolascione is busy at the moment. |
|
Did you leave the comments somewhere else outside of this PR, or Github simply doesn't show the review to me? I don't see the review here, and I want to follow the discussion thread 🙂 Screenshot |
|
That's the link to this PR, and I don't see any comments. I think you might have forgotten to click "Submit review", and until you do that, nobody except you sees the comments. |
| } | ||
| } | ||
| if (!cell_for_pos(w, &x, &y, global_state.callback_os_window)) return; | ||
| if (!cell_for_pos(w, &x, &y, global_state.callback_os_window)) { |
There was a problem hiding this comment.
This looks like an unnecessary change.
| OSWindow *callback_os_window; | ||
| Window *drag_start_window; | ||
| bool drag_start_in_tab_bar; | ||
| int drag_start_window_idx; |
There was a problem hiding this comment.
Tracking window pointers and window_idx is unsafe. Both can change at any time. Instead use the window id, which is guaranteed unique for the lifetime of kitty. As for window_idx, you should calculate it maually by iterating for the windows in the current tab, as window_for_event does anyway.
|
Wow, that's confusing :) I clicked submit review now should be fine. |
|
Yup, thanks, now @dcolascione has some work to do 😛 |
… strays into neighboring windows, the selection is still updated Fixes kovidgoyal#624
On mouse down, there's an "implicit grab" made by the window system
which ensures that mouse events are delivered to the window that
received the mouse-down even if the cursor strays outside the original
window before mouse-up. Kitty has been filtering out these
outside-window events and ignoring them, creating behavior that
differs from most other applications.
This change remembers the window bound to the mouse-down event and
uses it until mouse up, implementing more conventional moues behavior.