wl: Fix destroying CSDs in correct order (#3051) - #3066
Merged
Merged
Conversation
On Wayland, some compositors refuse to implement SSDs in which case we draw primitive CSDs. However, the destructors were called in the wrong order, leading to a dereference of an already freed object.
Contributor
|
Could you please also make a similar PR to GLFW? |
Contributor
Author
|
ah, sure! |
ljrk0
pushed a commit
to ljrk0/glfw
that referenced
this pull request
Oct 28, 2020
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051
elmindreda
pushed a commit
to glfw/glfw
that referenced
this pull request
Nov 30, 2020
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051 Closes #1798.
elmindreda
pushed a commit
to glfw/glfw
that referenced
this pull request
Dec 14, 2020
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051 Closes #1798. (cherry picked from commit 0dc1005)
elmindreda
pushed a commit
to glfw/glfw
that referenced
this pull request
Jan 31, 2021
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051 Closes #1798. (cherry picked from commit 0dc1005)
elmindreda
pushed a commit
to glfw/glfw
that referenced
this pull request
Feb 9, 2021
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051 Closes #1798. (cherry picked from commit 0dc1005)
swarnimarun
pushed a commit
to swarnimarun/glfw-meson
that referenced
this pull request
Jul 9, 2022
On Wayland we implement Client-Side Decorations if the compositors do not implement SSDs. In that case, the destructors of the surfaces were called in the wrong order, leading to a dereference of an already freed object. We need to first destroy the subsurface before destroying the parent surface. Related PR on kitty: kovidgoyal/kitty#3066 Related issue on kitty: kovidgoyal/kitty#3051 Closes glfw#1798. (cherry picked from commit 0dc1005)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland, some compositors refuse to implement SSDs in which case we draw
primitive CSDs. However, the destructors were called in the wrong order,
leading to a dereference of an already freed object.