Sextants: fix arithmetic mistake that broke 馃瑩, 馃, 馃 - #3105
Merged
Merged
Conversation
The scheme used in draw_sextant works well enough, but the feed was broken. 21 and 42 need to be skipped, not 20 and 40. Without this change, the following glyphs are broken: U+1FB13 BLOCK SEXTANT-35 馃瑩 renders as LEFT HALF U+1FB26 BLOCK SEXTANT-46 馃 renders as SEXTANT-146 U+1FB27 BLOCK SEXTANT-146 馃 renders as RIGHT HALF With this change, the entirety of the sextant block works correctly. Found debugging the Notcurses sextant blitter: dankamongmen/notcurses#1112
|
@kovidgoyal , you could at least thank the man |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheme used in draw_sextant works well enough, but the
feed was broken. 21 and 42 need to be skipped, not 20 and
40. Without this change, the following glyphs are broken:
U+1FB13 BLOCK SEXTANT-35 馃瑩 renders as LEFT HALF
U+1FB26 BLOCK SEXTANT-46 馃 renders as SEXTANT-146
U+1FB27 BLOCK SEXTANT-146 馃 renders as RIGHT HALF
With this change, the entirety of the sextant block works
correctly. Found debugging the Notcurses sextant blitter:
dankamongmen/notcurses#1112
Closes #3106