Directories should have MIME type inode/directory. - #3836
Merged
Merged
Conversation
Contributor
|
Since |
Owner
|
Couple of comments:
|
Owner
|
Actually maybe name the parameter allow_filesystem_access rather than check_for_dirs |
Contributor
|
You can fix the CI failure by having two empty lines above and below the new function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, one can't assign a custom action to folders in hyperlinks because they aren't associated a MIME type. This is because python's
mimetypeslibrary doesn't include that mime type. You also can't add this in the.config/kitty/mime.typesfile because folders have no extension.This way any directories automatically get the right MIME type.