BREAK: dropped python3.9, support py3.10+, updated commitizen #4
Conversation
7816e18 to
5b04407
Compare
CONTRIBUTING.md
Outdated
|
|
||
| ```bash | ||
| docker run --rm -v $(pwd):/app -w /app --name cz-kpn kpnnl/cz-kpn:3.2.12 'cz ls' | ||
| docker run --rm -v $(pwd):/app -w /app --name cz-kpn kpnnl/cz-kpn:4.0.0 'cz ls' |
There was a problem hiding this comment.
keep the latest version here, all versions are automatically updated by cz in here:
Lines 4 to 9 in 6949330
There was a problem hiding this comment.
Don't update the CHANGELOG, commitizen will automatically create it, that's the whole point of using it
pyproject.toml
Outdated
| [tool.poetry] | ||
| name = "cz-kpn" | ||
| version = "3.2.12" | ||
| version = "4.0.0" |
There was a problem hiding this comment.
This is handled by commitizen automatically, revert this change
scripts/build
Outdated
| # scope: local development | ||
|
|
||
| docker build -t kpnnl/cz-kpn:3.2.12 . | ||
| VERSION=${1:-4.0.0} |
|
|
||
| ## Local development with pyenv | ||
|
|
||
| 1. Install pyenv (if not already installed): |
There was a problem hiding this comment.
I don't use pyenv and it doesn't work on my machine. Do we need this when we already have a github action with the matrix?
There was a problem hiding this comment.
no only usefull for local dev and testing with tox.
There was a problem hiding this comment.
Added a note and made more clear that it is useful in case of local dev and testing with tox
Dockerfile
Outdated
| @@ -1,4 +1,5 @@ | |||
| FROM python:3-alpine | |||
| ARG CZ_KPN_VERSION=4.0.0 | |||
There was a problem hiding this comment.
Use the current version as well here
.github/workflows/bump.yaml
Outdated
| jobs: | ||
| bump-version: | ||
| if: "!startsWith(github.event.head_commit.message, 'BUMP:')" | ||
| if: startsWith(github.event.head_commit.message, 'BUMP:') == false |
There was a problem hiding this comment.
In most project we have been doing this:
if: ${{ !startsWith(github.event.head_commit.message, 'BUMP:') }}
do you know if your suggestion would work?
There was a problem hiding this comment.
I was getting some review comments from copilot that double quotes were not correct (it would be interpreted as string) and without it, !startsWith was not recognized.
But changed it to ${{ !startsWith(github.event.head_commit.message, 'BUMP:') }} which seems to be accepted too.
5b04407 to
4c2caab
Compare
4c2caab to
9950f2c
Compare
No description provided.