BREAK: dropped python3.9, support py3.10+, updated commitizen by eschaar · Pull Request #4 · kpn/cz-kpn

eschaar · 2025-10-10T11:01:03Z

No description provided.

woile · 2025-10-10T11:07:42Z

CONTRIBUTING.md


 ```bash
-docker run --rm -v $(pwd):/app -w /app --name cz-kpn kpnnl/cz-kpn:3.2.12 'cz ls'
+docker run --rm -v $(pwd):/app -w /app --name cz-kpn kpnnl/cz-kpn:4.0.0 'cz ls'


keep the latest version here, all versions are automatically updated by cz in here:

cz-kpn/.cz.toml

Lines 4 to 9 in 6949330

version_files = [

"scripts/build",

"CONTIRBUTING.md",

"Dockerfile:cz-kpn==",

"README.md:^docker"

]

woile · 2025-10-10T11:08:50Z

CHANGELOG.md

Don't update the CHANGELOG, commitizen will automatically create it, that's the whole point of using it

woile · 2025-10-10T11:09:34Z

pyproject.toml

 [tool.poetry]
 name = "cz-kpn"
-version = "3.2.12"
+version = "4.0.0"


This is handled by commitizen automatically, revert this change

woile · 2025-10-10T11:10:18Z

scripts/build

 # scope: local development

-docker build -t kpnnl/cz-kpn:3.2.12 .
+VERSION=${1:-4.0.0}


Revert to version 3.2.12

woile · 2025-10-10T11:11:11Z

PYTHON_TESTING.md

+
+## Local development with pyenv
+
+1. Install pyenv (if not already installed):


I don't use pyenv and it doesn't work on my machine. Do we need this when we already have a github action with the matrix?

no only usefull for local dev and testing with tox.

Added a note and made more clear that it is useful in case of local dev and testing with tox

woile · 2025-10-10T11:17:50Z

Dockerfile

@@ -1,4 +1,5 @@
 FROM python:3-alpine
+ARG CZ_KPN_VERSION=4.0.0


Use the current version as well here

woile · 2025-10-10T11:19:18Z

.github/workflows/bump.yaml

 jobs:
  bump-version:
-    if: "!startsWith(github.event.head_commit.message, 'BUMP:')"
+    if: startsWith(github.event.head_commit.message, 'BUMP:') == false


In most project we have been doing this:

if: ${{ !startsWith(github.event.head_commit.message, 'BUMP:') }}

do you know if your suggestion would work?

I was getting some review comments from copilot that double quotes were not correct (it would be interpreted as string) and without it, !startsWith was not recognized.

But changed it to ${{ !startsWith(github.event.head_commit.message, 'BUMP:') }} which seems to be accepted too.

eschaar force-pushed the feature/upgrade branch from 7816e18 to 5b04407 Compare October 10, 2025 11:04

woile reviewed Oct 10, 2025

View reviewed changes

eschaar force-pushed the feature/upgrade branch from 5b04407 to 4c2caab Compare October 10, 2025 11:43

BREAK: dropped python3.9, support py3.10+, updated commitizen

9950f2c

eschaar force-pushed the feature/upgrade branch from 4c2caab to 9950f2c Compare October 10, 2025 11:46

woile approved these changes Oct 10, 2025

View reviewed changes

woile merged commit 85f0341 into kpn:main Oct 10, 2025
4 checks passed

	version_files = [
	"scripts/build",
	"CONTIRBUTING.md",
	"Dockerfile:cz-kpn==",
	"README.md:^docker"
	]


		## Local development with pyenv

		1. Install pyenv (if not already installed):

Conversation

eschaar commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants