Repository navigation
Fix detection of installed Epic base games with empty parent names - #6953
Open
snowyukitty wants to merge 1 commit into
Open
snowyukitty wants to merge 1 commit into
snowyukitty wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6899.
An installed base game such as Caravan SandWitch can have an empty
MainGameAppName. The manifest scanner currently treats that as a different parent and skips the game. Accept the empty string as well as an exactAppNamematch, while retaining the exclusion for manifests naming another parent.The tests cover the scanner and the real installed-game import into temporary SQLite and YAML state. They verify both base-game formats, DLC exclusion, unchanged rows on a second scan, the launcher executable, and the game-specific launch URI. Both empty-parent regressions fail against the unmodified scanner.
Validation from the repository root on Ubuntu 24.04 / Python 3.12:
nose2 --exclude-ci -v: 586 tests run, 1 existing Nvidia-driver test skipped.ruff check .andruff format . --check.mypy . --python-version 3.10.python3 utils/check_annotations.py.python -m compileall -q lutris/ tests/services/_test_egs.py tests/util/_test_egs_launcher.py.The offline suite had the official Libretro core metadata populated beforehand. The import test replaces media downloading only. GUI interaction, Epic authentication, and launching Caravan SandWitch were not tested.