Skip to content

fix(vg_lite): align the stride alignment algorithm with the vg_lite_allocate - #10752

Open
FASTSHIFT wants to merge 1 commit into
lvgl:masterfrom
FASTSHIFT:fix_vg_lite_stride_calc
Open

FASTSHIFT wants to merge 1 commit into
lvgl:masterfrom
FASTSHIFT:fix_vg_lite_stride_calc

Conversation

@FASTSHIFT

Copy link
Copy Markdown
Collaborator

Fully align the stride calculation algorithm with the vg_lite_allocate API of the vg_lite driver to avoid false positives during the lv_vg_lite_buffer_check stride verification.

Notes

…llocate

Signed-off-by: lijianjun <lijianjun@xiaomi.com>
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

PR report

Check Result
Static Checks all checks passed
⚠️ Coverage not available, the tests did not finish
Performance no change in render_time
Memory Usage no change
Performance — no change in render_time
Configuration render_time (ms) vs master
32b lv_conf_perf32b 19 no change
64b lv_conf_perf64b 17 no change

The full per-scene tables are in the job summary.

Memory Usage — no change

Linked image (--gc-sections)

Target Config Flash master Δ Flash RAM Δ RAM
arm-cortex-m4 standard 381.926 KB 381.926 KB +0 B 365.559 KB +0 B
arm-cortex-m4 rgb565 340.785 KB 340.785 KB +0 B 365.559 KB +0 B
arm-cortex-m4 minimal 156.406 KB 156.406 KB +0 B 75.746 KB +0 B
arm-cortex-m0plus standard 392.184 KB 392.184 KB +0 B 365.559 KB +0 B
arm-cortex-m0plus rgb565 348.312 KB 348.312 KB +0 B 365.559 KB +0 B
arm-cortex-m0plus minimal 164.464 KB 164.464 KB +0 B 75.746 KB +0 B
xtensa-esp32 standard 405.805 KB 405.805 KB +0 B 365.582 KB +0 B
xtensa-esp32 rgb565 354.602 KB 354.602 KB +0 B 365.582 KB +0 B
xtensa-esp32 minimal 175.027 KB 175.027 KB +0 B 75.746 KB +0 B
riscv32-esp32c3 standard 417.809 KB 417.809 KB +0 B 365.582 KB +0 B
riscv32-esp32c3 rgb565 369.906 KB 369.906 KB +0 B 365.582 KB +0 B
riscv32-esp32c3 minimal 178.504 KB 178.504 KB +0 B 75.746 KB +0 B

LVGL library, nothing dead-stripped

liblvgl.a in full. The linked image above only contains what the test application reaches. Useful to know how much memory LVGL will require when using a binding like MicroPython

Target Config Library master Δ
arm-cortex-m4 standard 339.410 KB 339.410 KB +0 B
arm-cortex-m4 rgb565 301.298 KB 301.298 KB +0 B
arm-cortex-m4 minimal 228.775 KB 228.775 KB +0 B
arm-cortex-m0plus standard 352.305 KB 352.305 KB +0 B
arm-cortex-m0plus rgb565 311.644 KB 311.644 KB +0 B
arm-cortex-m0plus minimal 238.922 KB 238.922 KB +0 B
xtensa-esp32 standard 437.639 KB 437.639 KB +0 B
xtensa-esp32 rgb565 387.404 KB 387.404 KB +0 B
xtensa-esp32 minimal 290.195 KB 290.195 KB +0 B
riscv32-esp32c3 standard 428.764 KB 428.764 KB +0 B
riscv32-esp32c3 rgb565 382.111 KB 382.111 KB +0 B
riscv32-esp32c3 minimal 284.627 KB 284.627 KB +0 B

Flash is text + data, RAM is data + bss.
Comparing 7d9fbae6c against 7cf49a06c.

Generated automatically

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/draw/vg_lite/lv_vg_lite_utils.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants